Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State improvements + QoL additions #91

Open
wants to merge 12 commits into
base: react-port
Choose a base branch
from

Conversation

0x96EA
Copy link
Contributor

@0x96EA 0x96EA commented Jun 15, 2024

So i went down a rabbit hole to fix the app state not being saved correctly and learned a lot about electron store... Please feel free to choose to use parts of the PR or redo it in a style you want. 😊

I optimized the number of calls that needed to be made to the store and keep the data in a context with a hook for the frontend. Have already seen the performance improvements and the app now "remembers things correctly".

List of changes

  • Setup context for interaction with electron-store see useStorageContext()
  • Added PIP button
  • Fixed memory leaks from the auto update ipc events being emitted but not being cleaned up.
  • Updated various useEffect calls
  • Fixed adding and removing shows from your list
  • Added shortcuts for Skip Intro ('s' key) and PIP ('o key')

Screenshots

Screenshot 2024-06-16 at 03 22 14

Skip Intro button moved to the left and Picture in picture button on the right


Screenshot 2024-06-16 at 03 22 33

Picture in picture on


Screenshot 2024-06-16 at 03 22 43

Picture in picture with mouse hovered over it


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant