Revert "account_usability: reset to draft the bank statement do not unreconcile items #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nreconcile" This reverts commit 85f8fe5.
bguillot
approved these changes
Feb 8, 2024
github-grap-bot
deleted the
14-account-usability-fix-statement-back-to-draft
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #174
There is an unresolved issue on the subject : #191
Today when we click on the reset to draft button, all reconciliation are removed, but the bank statement line is still considered as done/reconciled.
It is very, very error prone and if you want then add the reconciliation back, you have to revert the reconciliation line anyway...
I can't see how it is usable, and it is very error prone.
The reconciliation are removed because all bank statement accounting entries are reseted to draft. If we want to keep this functionality, we'd have to check if it is possible/reasonable to have draft account move lines reconciled, or if we can do a "reset to draft" but keeping the statement accounting entries as posted.
I am not sure what was the initial goals, but if it is to be able to add a line or change a line, I guess we'd better to just allow changes in a posted bank statement...
Please, let's merge this PR soon, and if you really want to continue with it, do it in a separated module...
@sebastienbeau @alexis-via @bguillot