Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] product_inventoriable module #242

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][ADD] product_inventoriable module #242

wants to merge 1 commit into from

Conversation

chafique-delli
Copy link
Member

No description provided.

@chafique-delli
Copy link
Member Author

@sebastienbeau

sebastienbeau
sebastienbeau requested changes Aug 22, 2022
View reviewed changes
Copy link
Member

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you miss to develop the feature.
We should only add in the inventory the product that have been flag "to_inventory"

product_inventoriable/models/product_template.py Outdated

to_inventory = fields.Boolean("To inventory", default=True)

def write(self, vals):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastienbeau

@chafique-delli chafique-delli force-pushed the 14.0-ADD-product_inventoriable branch 4 times, most recently from 6a391ff to ccdd566 Compare August 31, 2022 11:07
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Merging #242 (c64ad28) into 14.0 (6fb5e3d) will increase coverage by 0.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             14.0     #242      +/-   ##
==========================================
+ Coverage   79.98%   80.62%   +0.64%     
==========================================
  Files         123      130       +7     
  Lines        1354     1399      +45     
  Branches      260      266       +6     
==========================================
+ Hits         1083     1128      +45     
  Misses        232      232              
  Partials       39       39
Files Coverage Δ
product_inventoriable/__init__.py 100.00% <100.00%> (ø)
product_inventoriable/models/__init__.py 100.00% <100.00%> (ø)
product_inventoriable/models/product_template.py 100.00% <100.00%> (ø)
product_inventoriable/models/stock_inventory.py 100.00% <100.00%> (ø)
product_inventoriable/models/stock_quant.py 100.00% <100.00%> (ø)
product_inventoriable/tests/__init__.py 100.00% <100.00%> (ø)
..._inventoriable/tests/test_product_inventoriable.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienbeau sebastienbeau sebastienbeau requested changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chafique-delli @sebastienbeau @github-grap-bot