Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search/replace for line break #5027

Closed
wants to merge 1 commit into from
Closed

Conversation

sekedus
Copy link

@sekedus sekedus commented Jan 18, 2023

Issue #2869

Description of changes:

  • highlight line break
  • search line break
  • replace line break

Test:

Auto detect multiline, if regexp active and searchBox contains line break character \n

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* highlight line break
* search line break
* replace line break
@akoreman
Copy link
Contributor

akoreman commented Mar 8, 2023

Thanks for your contribution. Could you expand the description of the PR with a bit more context on what this PR aims to do.

if (callback(row, column, row, column + length))
if (multiline) {
var pos = multilineBackward(re, endIndex, row, firstRow);
// console.log(pos);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be removed.


this.update = function(html, markerLayer, session, config) {
if (!this.regExp)
return;
var start = config.firstRow, end = config.lastRow;
var multiline = this.isMultilineSearch();
console.log(multiline);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This console.log should probably not be here.

@akoreman
Copy link
Contributor

akoreman commented Aug 2, 2023

Closing due to inactivity, feel free to reopen if you want to start working on the PR again.

@akoreman akoreman closed this Aug 2, 2023
@sekedus
Copy link
Author

sekedus commented Nov 15, 2024

continues to #5675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants