Apply Aiven-specific changes on top of upstream 5.0-rc1 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 8 has been removed. Lowest supported version is Java 11. After a security review, we decided to use the commit SHA from 2.16.1 for publish-unit-test-result-action.
Joining nodes receive their backup from Astacus. The exchange of SSTables during node replacement is not necessary.
We decorate standard PasswordAuthenticator with a few platform specific features, that don't change the externally observable behavior - so it's absolutely compatible with PasswordAuthenticator. A few tools and client libraries do not support custom authenticators. For example: ZDM Proxy. They fail whenever they see anything but PasswordAuthenticator nevertheless they are in fact completely compatible. So we want to stop advertising our custom authenticator and pretend that it's a standard PasswordAuthenticator.
tilman-aiven
force-pushed
the
aiven-5.0-rc1-test
branch
from
5902f55
to
48e8ece
Compare
Test Results9 961 tests 9 901 ✅ 2h 34m 18s ⏱️ For more details on these failures, see this check. Results for commit 48e8ece. |
tilman-aiven
commented
Jul 5, 2024
| /** | ||
| * A class that contains Aiven-specific configuration properties for the node it runs within. | ||
| */ | ||
| public class AivenConfig |
There was a problem hiding this comment.
VIOLATION: org.apache.cassandra.config.AivenConfig
at org.apache.cassandra.config.DatabaseDescriptorRefTest.checkViolations(DatabaseDescriptorRefTest.java:438)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently not intended for merge.