Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer support #23

Closed
wants to merge 3 commits into from
Closed

Footer support #23

wants to merge 3 commits into from

Conversation

evil159
Copy link

@evil159 evil159 commented Feb 6, 2019

Details

This PR adds footer support to MagazineLayout.

Related Issue

#18

Motivation and Context

Footers are quite common when dealing with collection view sections.

How Has This Been Tested

Tested using the example project and unit tests.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@evil159 evil159 mentioned this pull request Feb 6, 2019
Closed
@bryankeller
Copy link
Contributor

@evil159 thanks so much for taking on this work! I've been a bit busy, but will be able to look at this next week. Thank you for your patience 🙂

@bryankeller bryankeller self-requested a review February 15, 2019 09:47
@bryankeller bryankeller added the enhancement New feature or request label Feb 15, 2019
@diegorozen
Copy link
Contributor

@bryankeller Is there anything blocking this PR. It would be a great addition to the library. Thanks again!

This was referenced Apr 4, 2019
Closed
Merged
@bryankeller
Copy link
Contributor

Closing in favor of #31 - please take a look @evil159

@bryankeller bryankeller closed this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryankeller bryankeller Awaiting requested review from bryankeller

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evil159 @bryankeller @diegorozen