chg: Improve errors handling, make settings more strict.

lacuscore/helpers.py

@@ -4,7 +4,7 @@
 
 from enum import IntEnum, unique
 from logging import LoggerAdapter
-from typing import MutableMapping, Any, TypedDict
+from typing import MutableMapping, Any, TypedDict, Literal
 
 from playwrightcapture.capture import CaptureResponse as PlaywrightCaptureResponse
 
@@ -77,7 +77,7 @@ class CaptureSettings(TypedDict, total=False):
     url: str | None
     document_name: str | None
     document: str | None
-    browser: str | None
+    browser: Literal['chromium', 'firefox', 'webkit'] | None
     device_name: str | None
     user_agent: str | None
     proxy: str | dict[str, str] | None

lacuscore/lacuscore.py

@@ -30,7 +30,7 @@
 from dns.exception import Timeout as DNSTimeout
 
 from defang import refang  # type: ignore[import-untyped]
-from playwrightcapture import Capture, PlaywrightCaptureException
+from playwrightcapture import Capture, PlaywrightCaptureException, InvalidPlaywrightParameter
 from redis import Redis
 from redis.exceptions import ConnectionError as RedisConnectionError
 from redis.exceptions import DataError
@@ -603,7 +603,7 @@ async def _capture(self, uuid: str, priority: int) -> None:
                             stats_pipeline.zincrby(f'stats:{today}:errors', 1, result['error_name'])
             except RetryCapture as e:
                 raise e
-            except PlaywrightCaptureException as e:
+            except (PlaywrightCaptureException, InvalidPlaywrightParameter) as e:
                 logger.warning(f'Invalid parameters for the capture of {url} - {e}')
                 result = {'error': f'Invalid parameters for the capture of {url} - {e}'}
                 raise CaptureError(f'Invalid parameters for the capture of {url} - {e}')