Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] gbp-pull: similar force update strategy for all branches #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jan 29, 2018

Follow-up from #39. This patch is probably not ready for merging, but, a base for discussion.

Discussion from #39

I still think there is something broken in the gbp-pull logic when --force is used. The currently checked-out branch is merged but the others are just reset which I see kind of bad because the end result depends on the currently checked out branch. For example, if I happened to be on pq branch the debian branch would be simply reseted to whatever the upstream has. But, if I happened to be on the debian branch it would be merged, instead. Any thoughts?

@agx
Copy link
Owner

agx commented Feb 3, 2018

This would also fix http://bugs.debian.org/875852

@marquiz
Copy link
Contributor Author

marquiz commented Sep 14, 2018

ping @agx, any thoughts on this?

@marquiz marquiz force-pushed the feature/gbp-pull branch 2 times, most recently from 18e4242 to 9d1bc83 Compare September 17, 2018 11:38
When using --force, treat non-checked-out branches similarly to the
current branch. That is, do git merge, instead of just setting the ref.

Also, renames fast_forward_branch() to update_branch() to better match
the functionality.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants