-
-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(refactor): w/blist transform args shouldn't be optional
- the array passed into the transforms should be required - same for arrToDict function - they're now called only when array is defined, and I think that behavior is more intuitive -- it should error if the array isn't defined - (test): in internal usage, they're never undefined, so this was reducing coverage because it was dead code - if the transforms were to eventually be externally visible / import-able, they should definitely throw an error in that case too -- if external users pass undefined to it - and the typings change means it'll happen at design-time too - definitely think it's more intuitive for external users this way too - (docs): use this commit for w/blist transform examples - or a variant of this commit -- just one where arr is required
- Loading branch information
Showing
4 changed files
with
4 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters