Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split and xdist for pytest #43

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Conversation

kaitj
Copy link
Contributor

@kaitj kaitj commented Sep 27, 2023

Proposed changes
The current tests take 10+ minutes, with the majority of this due to the generation and permutation of different transformations, as well as generation of complete AfidSets. This PR adds pytest-split and pytest-xdist in an attempt to speed up the testing (which would presumably get longer with more code added). I've also added the .test_duration generation as part of the poe test task, however the onus would still be on the contributor to run this.

Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Sep 27, 2023
@kaitj kaitj linked an issue Sep 27, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #43 (8a31c8c) into main (415cf15) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          653       654    +1     
=========================================
+ Hits           653       654    +1     
Components Coverage Δ
afids_utils/afids.py ∅ <ø> (∅)
afids_utils/ext 100.00% <ø> (ø)
afids_utils/transforms.py 100.00% <ø> (ø)

@kaitj kaitj merged commit 2b54577 into afids:main Oct 2, 2023
23 checks passed
@kaitj kaitj deleted the maint/pytest-boost branch October 2, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Test Splitting
2 participants