docs: Fix HeaderMatchingFilter example #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example should tag emails from Redmine with two tags: a fixed "redmine" and a dynamic one based on the project name. However, the configuration does something different: It tags *ALL* emails with the "redmine" tag and additionally tags emails with the "X-Redmine-Project" header with its content. The reason for tagging all emails is that a missing header is considered having an empty value and the pattern matches an empty string. The fix is to ensure that the pattern does not match an empty string.
|
Hey, |
GuillaumeSeren
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example should tag emails from Redmine with two tags: a fixed "redmine" and a dynamic one based on the project name. However, the configuration does something different: It tags ALL emails with the "redmine" tag and additionally tags emails with the "X-Redmine-Project" header with its content. The reason for tagging all emails is that a missing header is considered having an empty value and the pattern matches an empty string.
The fix is to ensure that the pattern does not match an empty string.