Skip to content

Commit

Permalink
Update self signed certs flag inline with oc
Browse files Browse the repository at this point in the history
  • Loading branch information
Aiden Keating committed Apr 4, 2018
1 parent b9bd1a9 commit dd14003
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/cmd/clientConfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func NewClientConfigCmd(k8Client kubernetes.Interface, mobileClient mobile.Inter
// GetClientConfigCmd returns a cobra command object for getting client configs
func (ccc *ClientConfigCmd) GetClientConfigCmd() *cobra.Command {
var includeCertificatePins bool
var allowSelfSignedCerts bool
var skipTLSVerification bool

cmd := &cobra.Command{
Use: "clientconfig <clientID>",
Expand Down Expand Up @@ -137,7 +137,7 @@ kubectl plugin mobile get clientconfig`,

// If the flag is set then include another key named 'https' which contains certificate hashes.
if includeCertificatePins {
servicePinningHashes, err := retrieveHTTPSConfigForServices(outputJSON.Services, allowSelfSignedCerts)
servicePinningHashes, err := retrieveHTTPSConfigForServices(outputJSON.Services, skipTLSVerification)
if err != nil {
return errors.Wrap(err, "Could not append HTTPS configuration for services")
}
Expand Down Expand Up @@ -170,7 +170,7 @@ kubectl plugin mobile get clientconfig`,
return nil
})

cmd.Flags().BoolVar(&allowSelfSignedCerts, "allow-self-signed-certs", false, "include certificate hashes for services with invalid/self-signed certificates")
cmd.Flags().BoolVar(&skipTLSVerification, "insecure-skip-tls-verify", false, "include certificate hashes for services with invalid/self-signed certificates")
cmd.Flags().BoolVar(&includeCertificatePins, "include-cert-pins", false, "include certificate hashes for services in the client config")
return cmd
}

0 comments on commit dd14003

Please sign in to comment.