feat: cake day 🍰 #627
Merged
feat: cake day 🍰 #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'll check it out shortly |
|
@aeharding so with the current patch, people who have just created an account < 24h also shows as cake day. is this the way its supposed to work? |
|
Will this show the icon at different times for people in different time zones? |
time is not taken into account when comparing today's date and the published date. so I think it shouldn't be an issue, since both dates are converted to local time? 🤔 |
sharunkumar
force-pushed
the
cake-day
branch
from
96b066b
to
d5d18bc
Compare
|
Logic should now take everything into account - and also not show cake day for brand new users. :) I added some tests too in case more edge cases come up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #59