Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix separate in perf #926

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix separate in perf #926

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac42d80
Fix separate in Perf
LongyuZhang Oct 29, 2024
a9f4e93
Fix separator in Perf
LongyuZhang Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test-result-summary-client/src/PerfCompare/lib/PerffarmRunJSON.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ export default class PerffarmRunJSON {
let indexOfMean = null;
let indexOfCI = null;

// Find the indexes of the variant seperators
// Find the indexes of the variant separators
for (let j = 0; j < this.parsedCSV.length; j++) {
// Each variant is seperated by a 1 element array
// Each variant is separated by a 1 element array
if (this.parsedCSV[j].length === 1) {
variantIndex.push(j);

// The excel file is seperated into two portions, the upper showing the detailed
// The excel file is separated into two portions, the upper showing the detailed
// benchmark results (which is needed) and the bottom showing a comparison if any.
// The seperation point is either:
// The separation point is either:
// two back to back arrays with length 1 OR
// an array of length 1 followed by an array of length 2
if (
Expand Down Expand Up @@ -133,11 +133,11 @@ export default class PerffarmRunJSON {
curMetricObject = { value: {} };
curMetricObject['name'] =
this.parsedCSV[variantIndex[k] + 1][m];
// Mean is always 6 indices above the next variant seperator
// Mean is always 6 indices above the next variant separator
curMetricObject['value']['mean'] =
this.parsedCSV[indexOfMean][m];

// Confidence Interval is always 4 indices above the next variant seperator
// Confidence Interval is always 4 indices above the next variant separator
try {
curMetricObject['value']['CI'] =
this.parsedCSV[indexOfCI][m];
Expand Down
Loading