Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add name fallback for GitHub users #152

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: add name fallback for GitHub users #152

merged 1 commit into from
Jun 17, 2024

Conversation

Bricklou
Copy link
Contributor

πŸ”— Linked issue

#150

❓ Type of change

Ensure users will always have a name, even if no display name is defined on their GitHub account. This is done by doing a fallback on the login name.

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #150

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@RomainLanz RomainLanz merged commit 07e4ce8 into adonisjs:develop Jun 17, 2024
5 checks passed
@RomainLanz
Copy link
Member

Thanks!

@Bricklou Bricklou deleted the patch-1 branch June 17, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github driver doesn't take in account user with only a login and no name
2 participants