Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-894 - Action running in local cannot be debugged #129

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Aug 23, 2020

Fixes #128

How Has This Been Tested?

npm test

and

aio app init
aio app run --local

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #129   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          870       873    +3     
  Branches       178       181    +3     
=========================================
+ Hits           870       873    +3     
Impacted Files Coverage Δ
lib/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c47f6...81641aa. Read the comment docs.

@shazron shazron marked this pull request as ready for review August 24, 2020 05:25
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart for the AIO_ vs AIO__ comment also captured in adobe/aio-lib-core-config#49 , lgtm

lib/utils.js Show resolved Hide resolved
@shazron shazron merged commit 1ccdf4b into master Aug 24, 2020
@shazron shazron deleted the ACNA-894 branch August 24, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACNA-894 - Action running in local cannot be debugged
2 participants