Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-3251 - tests fail for winston >= 3.13 #60

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Nov 7, 2024

Description

fixes #58

How Has This Been Tested?

  • npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3fcd2a6) to head (142d17e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          132       132           
  Branches        24        24           
=========================================
  Hits           132       132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron merged commit 8d4dc45 into master Nov 8, 2024
8 checks passed
@shazron shazron deleted the story/ACNA-3251 branch November 8, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail for winston >= 3.13
3 participants