fix: Use fallback languages for analytics summaries #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winged
reviewed
Nov 28, 2024
caluma/extensions/events/form.py
Outdated
Comment on lines
106
to
120
| def get_translation_with_fallback(value): | ||
| lang = get_language() | ||
| fallback_langs = ["en", "de"] | ||
| fallback_langs.remove(lang) | ||
| translated = getattr(value, lang) | ||
| if not translated: | ||
| for fl in fallback_langs: | ||
| translated = getattr(value, fl) | ||
| if translated: | ||
| break | ||
| return translated | ||
|
|
||
|
|
There was a problem hiding this comment.
Could probably be avoided by configuring localized fields, no?
https://django-localized-fields.readthedocs.io/en/latest/settings.html#localized-fields-fallbacks
There was a problem hiding this comment.
This is what we have already. But they just reported that this is not just a problem with the summaries, but with Analytics in general. I will have another look until continuing with this.
There was a problem hiding this comment.
Those are two different things. I've made an issue for it in Caluma.
Somehow the LOCALIZED_FIELDS_FALLBACKS setting doesn't get picked up. We need this, so I'm gonna merge anyway.
open-dynaMIX
force-pushed
the
summary_fallback_languages
branch
from
a052463
to
6bcf903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.