Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin Script, Version Catlogues, Kotlin Sample, Compose Sample #68

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Doomsdayrs
Copy link

@Doomsdayrs Doomsdayrs commented Jul 22, 2024

Various things to ensure the library is up to date.

I likely will use this library in production soon, thus why I put effort into converting (it helps me understand how the app and library is designed)

Its more idiomatic & JVM like compared Groovy.

Also is the new standard.
Upgrades Gradle to 8.9
Various improvements.

1. Compose to be up to date with android standards.
2. Kotlin since Java is no longer the programming language for Android.
3. Coroutines instead of threads for better multithreaded management.
4. Flows instead of LiveData
5. Document the code somewhat.
@Robyer
Copy link
Member

Robyer commented Jul 26, 2024

Hi, thanks for the PR.

I have some refactoring of the project in progress - specifically separating Leptonica and Tesseract as standalone projects/libraries to be consumed using prefab, but I had some problems with JitPack, so I need to finish these first.

Also I'm not ready to fully switch to Kotlin yet. Could you for now extract your modified sample into own module, let's say sample-ktx and create PR for it without affecting other modules code? I would merge that right now, then handle other things (like the migration from Groovy to Kotlin) later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants