Skip to content

Commit

Permalink
Merge branch 'cardano-foundation:master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
adamrusch authored Nov 3, 2024
2 parents b699251 + 279c56e commit 97ee631
Show file tree
Hide file tree
Showing 13 changed files with 1,384 additions and 54 deletions.
98 changes: 64 additions & 34 deletions CIP-0001/README.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion CIP-0101/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
CIP: 101
Title: Integration of `keccak256` into Plutus
Title: Integration of keccak256 into Plutus
Status: Proposed
Category: Plutus
Authors:
Expand Down
20 changes: 16 additions & 4 deletions CIP-0105/README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
---
CIP: 105
Title: Conway era Key Chains for HD Wallets
Status: Proposed
Status: Active
Category: Wallets
Authors:
- Ryan Williams <ryan.williams@intersectmbo.org>
Implementors: []
Implementors:
- Eternl <https://eternl.io/>
- Lace <https://www.lace.io/>
- Mesh <https://meshjs.dev/>
- NuFi <https://nu.fi/>
- Ryan Williams <ryan.williams@intersectmbo.org>
- Pawel Jackobs <pawel.jakubas-ext@cardanofoundation.org>
- Typhon <https://typhonwallet.io/>
- Vespr <https://vespr.xyz/>
- Yoroi <https://yoroi-wallet.com/>
Discussions:
- https://github.com/cardano-foundation/cips/pulls/597
Created: 2023-09-22
Expand Down Expand Up @@ -250,11 +259,14 @@ See [Test Vectors File](./test-vectors.md).
- [Lace](https://chromewebstore.google.com/detail/lace-sanchonet/djcdfchkaijggdjokfomholkalbffgil?hl=en)
- [Yoroi](https://chrome.google.com/webstore/detail/yoroi-nightly/poonlenmfdfbjfeeballhiibknlknepo/related)
- [demos wallet](https://github.com/Ryun1/cip95-demos-wallet)
- [ ] The consitutional committee derivation paths are used by two implementations.
- [x] The constitutional committee derivation paths are used by two implementations.
- [csl-examples](https://github.com/Ryun1/csl-examples/)
- [cardano-addresses](https://github.com/IntersectMBO/cardano-addresses/)

### Implementation Plan

- [ ] Author to provide an example implementation inside a HD wallet.
- [x] Author to provide an example implementation inside a HD wallet.
- [csl-examples/cip-1852-keys.js](https://github.com/Ryun1/csl-examples/blob/main/examples/CIP-1852/cip-1852-keys.js)

## Copyright

Expand Down
66 changes: 66 additions & 0 deletions CIP-0127/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
---
CIP: 127
Title: ripemd-160 hashing in Plutus Core
Status: Proposed
Category: Plutus
Authors:
- Tomasz Rybarczy <tomasz.rybarczyk@iohk.io>
Implementors: []
Discussions:
- https://github.com/cardano-foundation/CIPs/pull/826
Created: 2024-05-22
License: Apache-2.0
---

## Abstract
This CIP follows closely the (CIP-0101)[^1] and proposes an extension of the current Plutus functions with another hashing primitive [`RIPEMD-160`](https://en.bitcoin.it/wiki/RIPEMD-160). Primary goal is to introduce compatibility with Bitcoin's cryptographic infrastructure.

## Motivation: why is this CIP necessary?

The [integration](https://github.com/cardano-foundation/CIPs/blob/master/CIP-0049/README.md) of the ECDSA and Schnorr signatures over the secp256k1 curve into Plutus was a significant step towards interoperability with Ethereum and Bitcoin ecosystems. However, full compatibility is still impossible due to the absence of the `RIPEMD-160` hashing algorithm in Plutus interpreter, which is a fundamental component of Bitcoin's cryptographic framework.
Most of common addresses in Bitcoin are derived from double [hashing procedure](https://learnmeabitcoin.com/technical/cryptography/hash-function/#hash160) involving `SHA-256` followed by `RIPEMD-160` function:
- [P2KH](https://learnmeabitcoin.com/technical/script/p2pkh/)
- [P2WPKH](https://learnmeabitcoin.com/technical/script/p2wpkh/)
- [P2SH](https://learnmeabitcoin.com/technical/script/p2sh/)
- [P2WSH](https://learnmeabitcoin.com/technical/script/p2wsh/)

Adding `RIPEMD-160` to Plutus would enhance the potential for cross-chain solutions between Cardano and Bitcoin blockchains and complements the set of primitives which we already have in that regard. It would allow for the verification of Bitcoin addresses and transactions on-chain. This addition enables also the verification of signed messages that identify the signer by the public key hash, which has not yet been witnessed on the Bitcoin blockchain.

The RIPEMD-160 is not only relevant to Bitcoin - other chains like [Cosmos](https://docs.cosmos.network/main/build/architecture/adr-028-public-key-addresses#legacy-public-key-addresses-dont-change) or [BNB](https://docs.bnbchain.org/docs/beaconchain/learn/accounts/#address) also use it for address generation.

## Specification
This proposal aims to introduce a new built-in hash function `RIPEMD-160`.

This function will be developed following the [`RIP-160`](https://homes.esat.kuleuven.be/~bosselae/ripemd160/pdf/AB-9601/AB-9601.pdf) specification and will utilize the [`cryptonite`](https://github.com/haskell-crypto/cryptonite/blob/master/Crypto/Hash/RIPEMD160.hs)

Since `cardano-base` already relies on `cryptonite` in the context of [`keccak-256`](https://github.com/input-output-hk/cardano-base/blob/master/cardano-crypto-class/src/Cardano/Crypto/Hash/Keccak256.hs) we would like to expose `RIPEMD-160` through the same library, to facilitate its integration into Plutus.

More specifically, Plutus will gain the following primitive operation:

* `ripemd_160` :: ByteString -> ByteString

The input to this function can be a `ByteString` of arbitrary size, and the output will be a `ByteString` of 20 bytes.
Note that this function aligns with the format of existing hash functions in Plutus, such as [blake2b_256](https://github.com/input-output-hk/plutus/blob/75267027f157f1312964e7126280920d1245c52d/plutus-core/plutus-core/src/Data/ByteString/Hash.hs#L25)

## Rationale: how does this CIP achieve its goals?
While the `RIPEMD-160` function might be implemented in on-chain scripts, doing so would be computationally unfeasible.

The library, cryptonite, is not implemented by and under control of the Plutus team. However,
* It is a library already used in the Plutus stack to expose KECCAK-256, and can be considered as a trustworthy implementation.
* Its behaviour is predictable and computationally efficient. The cost of the function is linear with respect to the size of the message provided as input. This is the same behaviour that other hash functions exposed in plutus (blake, sha3, keccak-256) have.

### Acceptance Criteria
- [X] A `cardano-base` binding is created for the `ripemd-160` function and included in a new version of the library.
- [X] A Plutus binding is created for the `ripemd_160` function and included in a new version of Plutus.
- [X] Integration tests, similar to those of the existing Plutus hash functions, are added to the testing infrastructure.
- [X] The function is benchmarked to assess its cost. As for other hash functions available in Plutus (blake2b, sha256 and keccak_256), we expect the cost of `ripemd_160` to be linear with respect to the size of the message. The Plutus team determines the exact costing functions empirically.
- [ ] The ledger is updated to include new protocol parameters to control costing of the new builtins.
- [ ] This CIP may transition to active status once the Plutus version containing the `ripemd_160` function is introduced in a node release and becomes available on Mainnet.

### Implementation Plan
The Plutus team will develop the binding, integration tests, and benchmarks. The E2E tests will be designed and implemented collaboratively by the testing team, the Plutus team, and community members planning to use this primitive.

## Copyright
This CIP is licensed under [Apache-2.0][https://www.apache.org/licenses/LICENSE-2.0].

[^1]: I did not hesitate to reuse parts of the original text of (CIP-0101)[../CIP-0101/README.md) without explicit quotations. This approach was approved by the original authors.
Loading

0 comments on commit 97ee631

Please sign in to comment.