Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple property assignments in KTS #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Goooler
Copy link

@Goooler Goooler commented Sep 15, 2023

@aSemy
Copy link
Contributor

aSemy commented Oct 5, 2023

Hey, thanks for updating to use the new property assignment! I'll get to this eventually, but it may take a couple of months - sorry.

The files in directories like examples/*/dokka/ should be copied from the head Dokka repo (automatically, with a Gradle task), so they shouldn't be modified.

I'm undecided on whether the Dokkatoo examples should also be updated. On one hand it's nice to use the latest and greatest, on the other it might make the examples too different and hinder the usefulness of the examples. Also, it would basically require Gradle 8.4 - and too many projects tend to be slow in updating Gradle. Keeping a wider compatibility would probably be better.

@martinbonnin
Copy link
Contributor

Another issue with the assignment overloads is that it makes it harder to copy/paste code between different contexts.

Valid Kotlin code in build.gradle.kts becomes wrong in buildSrc/src/main/kotlin or other "regular" places. I know it's the case for sam-with-receiver already and this might be a lost battle but I'd personally not rush migrating to the new syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants