Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS3231: Add support for fetching alarm values #257

Merged
merged 2 commits into from
Aug 4, 2022

Commits on Feb 9, 2022

  1. DS3231: Add support for fetching alarm values

    This commit introduces 4 new methods for DS3231 devices:
      - DateTime getAlarm1();
      - DateTime getAlarm2();
      - Ds3231Alarm1Mode getAlarm1Mode();
      - Ds3231Alarm2Mode getAlarm2Mode();
    
    The getAlarm methods assume that the alarms are stored
    using 24 hour format since this library doesn't support
    storing alarms in 12 hour format (DS3231 hardware supports
    this).
    
    Updated the DS3231_alarm example to fetch alarm1. Also
    improved the formatting of the serial logging.
    Justin Newitter committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    f5adeb7 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Apply suggestions from code review

    Handle edge case where the result of calling getAlarm is used to set the alarm
    and the mode is set to "Day"
    
    Co-authored-by: Edgar Bonet <edgar-bonet@users.noreply.github.com>
    justinnewitter and edgar-bonet authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    2596468 View commit details
    Browse the repository at this point in the history