Merge pull request #26 from ad-ha/ad-ha-0.4.6

Fix generic responses being parsed and not caught in exception
ad-ha · Nov 12, 2024 · 7585afa · 7585afa
2 parents e1bf2ce + c5eabba
commit 7585afa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/custom_components/mg_saic/coordinator.py b/custom_components/mg_saic/coordinator.py
@@ -84,6 +84,7 @@ async def _async_update_data(self):
                 if vehicle_status is None:
                     LOGGER.warning("Vehicle status returned None.")
                     raise UpdateFailed("Vehicle status is None.")
+
                 # Check for generic vehicle status response
                 self._is_generic_response(vehicle_status)
                 data["status"] = vehicle_status
@@ -166,6 +167,8 @@ def _is_generic_response(self, status):
                     "Generic vehicle status response received."
                 )
             return False
+        except GenericResponseException:
+            raise
         except Exception as e:
             LOGGER.error("Error: %s", e)
             return False
@@ -184,8 +187,10 @@ def _is_generic_charging_response(self, charging_info):
                         "Generic charging response received."
                     )
             return False
+        except GenericResponseException:
+            raise
         except Exception as e:
-            LOGGER.error("Error: %s", e)
+            LOGGER.error("Error:: %s", e)
             return False
 
     def _determine_vehicle_type(self, vehicle_info):

diff --git a/custom_components/mg_saic/manifest.json b/custom_components/mg_saic/manifest.json
@@ -12,5 +12,5 @@
         "pycryptodome",
         "saic-ismart-client-ng==0.5.2"
     ],
-    "version": "0.4.5"
+    "version": "0.4.6"
 }