-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maut 11460: Dynamic content in email builder filtered on custom object values #352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found several major/minor issues. Please address them. I will continue with my review once the issues are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my code comments.
@avikarshasaha will your changes work when there is a chain of custom items (Contact -> Custom Item -> Custom Item)? |
On today's DSU we decided not to support the chaining within this ticket/PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing if email variant have both custom object and lead type fields filter together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing if email variant have both custom object and lead type fields filter together.
Description:
Dynamic content in email builder filtered on custom object values
Steps to test this PR:
Create a segment email with dynamic content with one or more variations.
The variations should be based on the filters of Custom Object.
Then, trigger/preview the email to the selected contacts that fall under the configured variations.
Users should receive dynamic content depending on Custom Object filter
Other areas of Mautic that may be affected by the change:
List deprecations along with the new alternative:
List of areas covered by the unit and/or functional tests: