Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maut 11460: Dynamic content in email builder filtered on custom object values #352

Merged
merged 42 commits into from
Jul 18, 2024

Conversation

avikarshasaha
Copy link
Contributor

@avikarshasaha avikarshasaha commented Jun 18, 2024

Q A
Bug fix? (use the a.b branch) [ Y]
New feature/enhancement? (use the a.x branch) [ N]
Deprecations? [ N]
BC breaks? (use the c.x branch) [N ]
Automated tests included? [ Y]
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed https://acquia.atlassian.net/browse/MAUT-11460

Description:

Dynamic content in email builder filtered on custom object values

Steps to test this PR:

Create a segment email with dynamic content with one or more variations.
The variations should be based on the filters of Custom Object.
Then, trigger/preview the email to the selected contacts that fall under the configured variations.
Users should receive dynamic content depending on Custom Object filter

Other areas of Mautic that may be affected by the change:

List deprecations along with the new alternative:

List of areas covered by the unit and/or functional tests:

@avikarshasaha avikarshasaha changed the title Maut 11460 Maut 11460: Dynamic content in email builder filtered on custom object values Jun 18, 2024
@avikarshasaha avikarshasaha requested review from a team, fedys and dadarya0 and removed request for a team June 18, 2024 11:56
Copy link
Contributor

@fedys fedys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found several major/minor issues. Please address them. I will continue with my review once the issues are addressed.

EventListener/TokenSubscriber.php Outdated Show resolved Hide resolved
EventListener/TokenSubscriber.php Outdated Show resolved Hide resolved
EventListener/TokenSubscriber.php Outdated Show resolved Hide resolved
EventListener/TokenSubscriber.php Outdated Show resolved Hide resolved
EventListener/TokenSubscriber.php Outdated Show resolved Hide resolved
@avikarshasaha avikarshasaha requested a review from fedys June 20, 2024 07:50
Copy link
Contributor

@fedys fedys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my code comments.

EventListener/TokenSubscriber.php Outdated Show resolved Hide resolved
@fedys
Copy link
Contributor

fedys commented Jun 20, 2024

@avikarshasaha will your changes work when there is a chain of custom items (Contact -> Custom Item -> Custom Item)?

EventListener/TokenSubscriber.php Outdated Show resolved Hide resolved
@fedys
Copy link
Contributor

fedys commented Jun 21, 2024

@avikarshasaha will your changes work when there is a chain of custom items (Contact -> Custom Item -> Custom Item)?

On today's DSU we decided not to support the chaining within this ticket/PR.

Copy link
Contributor

@dadarya0 dadarya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing if email variant have both custom object and lead type fields filter together.

Copy link
Contributor

@dadarya0 dadarya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing if email variant have both custom object and lead type fields filter together.

dadarya0
dadarya0 previously approved these changes Jul 11, 2024
fedys
fedys previously approved these changes Jul 11, 2024
@avikarshasaha avikarshasaha dismissed stale reviews from fedys and dadarya0 via b0db023 July 12, 2024 05:22
fedys
fedys previously approved these changes Jul 12, 2024
dadarya0
dadarya0 previously approved these changes Jul 12, 2024
@avikarshasaha avikarshasaha dismissed stale reviews from dadarya0 and fedys via 8011c8b July 17, 2024 14:54
@avikarshasaha avikarshasaha merged commit 6ad2360 into staging Jul 18, 2024
3 checks passed
@avikarshasaha avikarshasaha deleted the MAUT-11460 branch July 18, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants