ACMS-1972: Fixing new search index field on field settings and storage page. #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apathak18
force-pushed
the
ACMS-1972
branch
from
c41051b
to
1bfcf98
Compare
apathak18
force-pushed
the
ACMS-1972
branch
from
1bfcf98
to
1acd6f3
Compare
apathak18
requested review from
chandan-singh7929,
vishalkhode1 and
rajeshreeputra
rajeshreeputra
approved these changes
Oct 3, 2023
apathak18
changed the title
chandan-singh7929
approved these changes
Oct 4, 2023
modules/acquia_cms_common/tests/src/ExistingSite/ContentTypeListTestBase.php
Show resolved
Hide resolved
| @@ -145,6 +145,7 @@ protected function createSampleContent(string $node_type) { | |||
| ]); | |||
| } | |||
| $this->drupalPlaceBlock('facet_block:search_category', ['region' => 'content']); | |||
| \Drupal::getContainer()->get('search_api.post_request_indexing')->destruct(); | |||
There was a problem hiding this comment.
Can we use $this->container->get('search_api.post_request_indexing')->destruct();
There was a problem hiding this comment.
getContainer method is static and with $this->container we won't get a destruct method CI repeats failing.
For example check below screenshot.
vishalkhode1
merged commit d573d0f
into
feature/acms-search-improvement
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes ACMS-1972
Proposed changes
Field storage and settings page throws error with new core improvement patches.