Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced java.util.Date with java.util.Instant and added test #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replaced java.util.Date with java.util.Instant and added test #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/codegen/fromcto/java/javavisitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ class JavaVisitor {
toJavaType(type) {
switch(type) {
case 'DateTime':
return 'java.util.Date';
return 'java.util.Instant';
case 'Boolean':
return 'boolean';
case 'String':
Expand Down
2 changes: 1 addition & 1 deletion test/codegen/fromcto/java/javavisitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ describe('JavaVisitor', function () {

describe('toJavaType', () => {
it('should return java.util.Date for DateTime', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test name

javaVisit.toJavaType('DateTime').should.deep.equal('java.util.Date');
javaVisit.toJavaType('DateTime').should.deep.equal('java.util.Instant');
});

it('should return boolean for Boolean', () => {
Expand Down