Implement OneDrive Business Shared Folders Support (Issue #459) #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
abraunegg
commented
Apr 23, 2019
abraunegg
commented
- Initial work on supporting OneDrive Business Shared Folders
* Inital work on supporting OneDrive Business Shared Folders
abraunegg
changed the title
|
How to configure
What has been tested
What is not working yet |
* Handle local deletes where item resides on a different drive id
This was referenced Apr 23, 2019
* Update --single-directory handling for OneDrive Business Shared Folders * Update debugging output * Update logging output as to why a 'change' was discarded * Fix bug where 'item path' contains 'syncFolderChildPath' would always be true as bad isItemRemote test was being used as qualifier
|
Further testing
|
|
@norbusan |
* Add readme on how to configure * Code cleanup
* Update shared folders readme * Fix crash when 5xx error is received when getDefaultRoot() is called * Update Business Shared Folder logic to handle when a local directory already exists but not synced * Update Business Shared Folder logic to handle namespace conflicts (2 different users sharing the same folder name)
* Update Business Shared Folder logic when handling existing items * Update readme
* Make codacy happy
* Some shared folders dont detail who it is shared by - not good for conflict resolution
* validate that parent reference id also exists before using
* add logic to look for shared folders where the shared folder is not the root folder being shared with us
* clean up merge
* update last ditch effort to match this onedrive shared folder
abraunegg
changed the title
* Update to handle feature via config file
|
@norbusan |
* Update documentation
norbusan
reviewed
Jun 19, 2020
norbusan
reviewed
Jun 19, 2020
norbusan
reviewed
Jun 19, 2020
norbusan
reviewed
Jun 19, 2020
* If sync_list contains a comment line, exclude this from sync_list processing * If business_shared_folders contains a comment line, exclude this from business_shared_folders processing
norbusan
reviewed
Jun 20, 2020
norbusan
reviewed
Jun 20, 2020
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
The very same code appears in line 3481, and maybe other places, can we get rid of these duplications? (Not necessary for this PR, but could be a separate ;-) )
norbusan
previously approved these changes
Jun 20, 2020
* Update from 'master' and resolve conflicts
* Only scan the database using the unique list of drive ID's to avoid multiple DB queries if drive ID is present multiple times
* Update Makefile based on change in filename
* Merge 'master' and resolve conflicts
* Update functions to match codin style
* Update how entries are added to driveIDsArray to ensure they are unique
* Update logging output to reflect the correct path based on what is actually shared, not the full underlying parent path
* code simplification
* PR logging tweaks
* Add known issue details of an API issue which prevents shared folders from outside an organisation being configured to sync, as the API does not provide them in the API response.
* Update documentation
* Add response error handling for graphQuery
* Use right URL
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.