Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for severity range #1179

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

ziadhany
Copy link
Collaborator

issue: #889

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!
can you add a screenshot to help visualize where this shows up?
@DennisClark your review is much welcomed

@DennisClark
Copy link
Member

@ziadhany one or more screenshots would be very helpful, thanks

@ziadhany
Copy link
Collaborator Author

@ziadhany one or more screenshots would be very helpful, thanks

ok sure

Screenshot 2023-04-21 at 23-31-25 VulnerableCode Vulnerability Details - VCID-12mr-dt14-aaah

Screenshot 2023-04-21 at 23-34-50 VulnerableCode Vulnerability Details - VCID-zmd4-akdr-aaab

image

and this if we have just one severity ( no severity range )
image

@DennisClark
Copy link
Member

@ziadhany looks good to me 👍

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@TG1999 TG1999 added this to the v33.0.0 milestone Sep 5, 2023
@TG1999 TG1999 merged commit 2800d6a into aboutcode-org:main Sep 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants