Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CWE support in the API #1116

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Add CWE support in the API #1116

merged 3 commits into from
Dec 29, 2023

Conversation

ziadhany
Copy link
Collaborator

@ziadhany ziadhany commented Feb 6, 2023

issue: #1094

Signed-off-by: ziadhany ziadhany2016@gmail.com

@TG1999
Copy link
Contributor

TG1999 commented Aug 22, 2023

@ziadhany please test the API for cases like this #1256. Also run the NVD importer and default improver once locally to verify that the CWEs not present in DB are well handled in the API.

@TG1999
Copy link
Contributor

TG1999 commented Sep 11, 2023

@ziadhany gentle reminder : )

Comment on lines 244 to 248
{
"cwe_id": 10000,
"name": "",
"description": "",
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 to remove this part should I edit the WeaknessSerializer ( add a validation function ) or what should I do ?

ziadhany and others added 3 commits December 29, 2023 16:46
Resolve merge conflict

issue: aboutcode-org#1094

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 merged commit 1600811 into aboutcode-org:main Dec 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants