Add :inhibit-quit property to improve performance
#422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit one can add the property `:inhibit-quit` to a head to prevent the hydra from exiting temporarily before calling that head. (It is intended to be used and only effective on non-exiting heads.) This greatly improves performance when calling heads repeatedly in quick succession, such as with scrolling or window resizing commands. In such cases the call to `hydra-keyboard-quit` (and the induced re-creation of the lv buffer and window) can quickly become the bottleneck and is often unnecessary. (It is only necessary in special cases, for example, when a head reads from the minibuffer, or when it saves and switches window configurations.) I would like to apply this option to the scrolling and window resizing hydra heads in Spacemacs, which currently suffer from relatively severe performance problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit one can add the property
:inhibit-quit tto a head to prevent the hydra from exiting temporarily before calling that head. (It is intended to be used and only effective on non-exiting heads.)This greatly improves performance when calling heads repeatedly in quick succession, such as with scrolling or window resizing commands. In such cases the call to
hydra-keyboard-quit(and the induced re-creation of the lv buffer and window) can easily become the bottleneck and is often unnecessary. (It is only necessary in special cases, for example, when a head reads from the minibuffer, or when it saves and switches window configurations.)I would like to apply this option to the scrolling and window resizing hydra heads in Spacemacs, which currently suffer from relatively severe performance problems.