Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from GNU ELPA #408

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

skangas
Copy link
Contributor

@skangas skangas commented Dec 31, 2021

This merges the changes from GNU ELPA as discussed here:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52902#8

Thanks!

monnier and others added 3 commits November 30, 2020 18:19
Most of these are minor issues involving, e.g., quoting `like this'
instead of 'like this'.  A few involve escaping ` and ' with a
preceding \= when the characters should not be turned into curved single
quotes.
@monnier
Copy link
Contributor

monnier commented Dec 31, 2021

Note that it's important to merge the metadata more than the contents, so please please pretty please don't squash it:
We need commit 4532f40 to be "contained" in this upstream repository before elpa.git can do a fast-forward to it.

@abo-abo
Copy link
Owner

abo-abo commented Jan 2, 2022

@monnier To squash it would be to simply close the PR, since it doesn't bring in any useful code: (require 'ring) is already there, and the quote problems fixed in the docstrings were in generated test code.

I'd really like to keep the linear commit history (no merge commits). I've done it for 7 years already. Is there a way to have auto-sync in GNU ELPA without merge commits?

@monnier
Copy link
Contributor

monnier commented Jan 2, 2022 via email

@monnier
Copy link
Contributor

monnier commented Feb 20, 2022 via email

@monnier
Copy link
Contributor

monnier commented May 3, 2022

Re-Ping?

@monnier
Copy link
Contributor

monnier commented Sep 26, 2022

Hello? Anybody there?

@basil-conto
Copy link

basil-conto commented Jun 10, 2024

I'd really like to keep the linear commit history (no merge commits). I've done it for 7 years already. Is there a way to have auto-sync in GNU ELPA without merge commits?

Yes, it's possible: I've been manually merging swiper.git into elpa.git, for example. I can volunteer to do the same for hydra.git if given access.

That said, my vote is against insisting on an unconditionally linear history.

@monnier
Copy link
Contributor

monnier commented Jun 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants