Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async version of channel status #1266

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Add async version of channel status #1266

merged 5 commits into from
Oct 17, 2023

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Oct 13, 2023 •
edited
Loading

@github-actions github-actions bot temporarily deployed to staging/pull/1266/features October 13, 2023 17:11 Inactive
@sacOO7 sacOO7 requested a review from marto83 October 13, 2023 17:53
@github-actions github-actions bot temporarily deployed to staging/pull/1266/features October 13, 2023 17:53 Inactive
marto83
marto83 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@marto83 marto83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@github-actions github-actions bot temporarily deployed to staging/pull/1266/features October 16, 2023 17:51 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review October 16, 2023 18:05
@sacOO7 sacOO7 requested a review from ttypic October 17, 2023 09:12
ttypic
ttypic approved these changes Oct 17, 2023
View reviewed changes
Copy link

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sacOO7 sacOO7 merged commit fd8f784 into main Oct 17, 2023
7 of 9 checks passed
@sacOO7 sacOO7 deleted the feature/status-async branch October 17, 2023 11:10
@sacOO7 sacOO7 mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

@ttypic ttypic ttypic approved these changes

@marto83 marto83 marto83 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Realtime Channel Status method
4 participants
@sacOO7 @marto83 @ttypic @owenpearson