Simplified processing of sync and normal presence message

ably · Sep 3, 2023 · 0a28b87 · 0a28b87
1 parent 8ccc633
commit 0a28b87
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/IO.Ably.Shared/Realtime/ChannelMessageProcessor.cs b/src/IO.Ably.Shared/Realtime/ChannelMessageProcessor.cs
@@ -147,11 +147,14 @@ public Task<bool> MessageReceived(ProtocolMessage protocolMessage, RealtimeState
                         channel.OnError(presenceDecodeResult.Error);
                     }
 
-                    string syncSerial = protocolMessage.Action == ProtocolMessage.MessageAction.Sync
-                            ? protocolMessage.ChannelSerial
-                            : null;
-
-                    channel.Presence.OnPresence(protocolMessage.Presence, syncSerial);
+                    if (protocolMessage.Action == ProtocolMessage.MessageAction.Sync)
+                    {
+                        channel.Presence.OnSyncMessage(protocolMessage);
+                    }
+                    else
+                    {
+                        channel.Presence.OnPresence(protocolMessage.Presence, null);
+                    }
 
                     break;
             }

diff --git a/src/IO.Ably.Shared/Realtime/Presence.cs b/src/IO.Ably.Shared/Realtime/Presence.cs
@@ -542,6 +542,11 @@ private bool PendingPresenceEnqueue(QueuedPresenceMessage msg)
             return true;
         }
 
+        internal void OnSyncMessage(ProtocolMessage protocolMessage)
+        {
+            OnPresence(protocolMessage.Presence, protocolMessage.ChannelSerial);
+        }
+
         internal void OnPresence(PresenceMessage[] messages, string syncChannelSerial)
         {
             try