Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Standarization of rpc block calls #237

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: Standarization of rpc block calls #237

wants to merge 11 commits into from

Conversation

giovannivignone
Copy link
Contributor

Standardization of RPC Calls + Testing

Testing documentation for RPC calls and adjustment of return values. Linking to issue #234

ToDos Before Merge

  • Add in all tests to helios tests dir
  • Standardize get_block_transaction_count_by_hash and get_block_transaction_count_by_number to return None on err similar to get_block_by_hash

Changes

  • rpc.rs Test file in helios tests package

@eshaan7
Copy link
Contributor

eshaan7 commented Nov 22, 2024

Standardize get_block_transaction_count_by_hash and get_block_transaction_count_by_number to return None on err similar to get_block_by_hash

Implemented in #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovannivignone @eshaan7