Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wasmtime flags for stable region unit testing #166

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Nov 6, 2023

This PR adds support for running WASI unit tests which include stable regions.

Implementation for mo-test: dfinity/motoko-dev-server#54.

Depends on dfinity/motoko#4256. We might make a few adjustments before this is ready to merge.

Copy link

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rvanasa!

@rvanasa rvanasa marked this pull request as ready for review November 11, 2023 17:03
@rvanasa
Copy link
Contributor Author

rvanasa commented Nov 11, 2023

Update: this is ready to merge!

@ZenVoich
Copy link
Owner

Thank you, @rvanasa !

@ZenVoich ZenVoich merged commit fe071ab into ZenVoich:main Nov 13, 2023
10 checks passed
@ZenVoich
Copy link
Owner

Released in mops cli 0.33.0

@rvanasa rvanasa deleted the ryan/wasmtime-stable-regions branch November 13, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants