Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Comment component fixes #46

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

mikecoomber
Copy link
Contributor

fix: onDelete now gets invoked correctly for ZetaComment
fix: Voice notes can now be disabled without the assertion failing

Copy link
Contributor

PR Checks complete

  • ✅ - Linting / Formatting
  • ✅ - Static analysis passed
  • ✅ - All tests passed
  • ✅ - Branch is not behind

Created with Flutter code quality action

Copy link
Contributor

Visit the preview URL for this PR (updated for commit f8beb46):

https://zds-c9c24--pr-46-fix-comment-component-fixes-33taa1yv.web.app

(expires Fri, 06 Dec 2024 16:18:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9e05e2ffbf7f11b6305259262f782e751f182319

@mikecoomber mikecoomber merged commit 5bf1345 into main Nov 29, 2024
4 checks passed
@mikecoomber mikecoomber deleted the fix/comment-component-fixes branch November 29, 2024 16:18
mikecoomber added a commit that referenced this pull request Nov 29, 2024
fix: Voice notes can now be disabled without the assertion failing (#46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants