Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying PHP version #223 #229

Open
wants to merge 2 commits into
base: testing
Choose a base branch
from
Open

Allow specifying PHP version #223 #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41eef9b
Allow specifying PHP version #223
fflorent Oct 7, 2023
adbd57c
Additional tests for PHP versions
fflorent Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion manifest.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ ram.runtime = "50M"
type = "group"
default = "visitors"

[install.phpversion]
ask.en = "Choose a PHP version you want to use for your app"
ask.fr = "Choisissez une version PHP que vous souhaitez utiliser pour votre application"
type = "select"
choices = ["8.0", "8.1", "8.2"]
default = "8.2"
Comment on lines +44 to +48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or i dunno, we should at least add an help key explaining that the default value is fine for regular use case and that some plugins are only compatible with older versions of php...


[install.language]
ask.en = "Choose the application language"
ask.fr = "Choisissez la langue de l'application"
Expand Down Expand Up @@ -73,7 +80,11 @@ ram.runtime = "50M"
admin.show_tile = false

[resources.apt]
packages = "mariadb-server, php8.2-mysql, php8.2-curl, php8.2-mbstring, php8.2-xml, php8.2-zip, php8.2-gd, php8.2-soap, php8.2-ssh2, php8.2-tokenizer, php8.2-ldap"
packages = "mariadb-server"
packages_from_raw_bash = """
echo "php${phpversion}-mysql php${phpversion}-curl php${phpversion}-mbstring php${phpversion}-xml php${phpversion}-zip php${phpversion}-gd php${phpversion}-soap"
echo "php${phpversion}-ssh2 php${phpversion}-tokenizer php${phpversion}-ldap"
"""

[resources.database]
type = "mysql"
14 changes: 14 additions & 0 deletions tests.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,17 @@ test_format = 1.0

args.language = "en_US"
args.multisite = 1

[with_php8.0]

only = ["install.subdir"]

args.language = "en_US"
args.phpversion = "8.0"

[with_php8.1]

only = ["install.subdir"]

args.language = "en_US"
args.phpversion = "8.1"