Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add href and target to Tx_Yag_Domain_Model_Item #56

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

[FEATURE] Add href and target to Tx_Yag_Domain_Model_Item #56

wants to merge 23 commits into from

Conversation

kersten
Copy link

@kersten kersten commented Jan 16, 2016

This feature makes it possible to save a custom link to the image. This makes it possible to build a theme where you can link a image to a custom site instead of opening the image or lightbox it.

This was needed for a so called "Sponsors Logo List" wehre my customer wanted a list of brands and on klick the website should open in a new window.

Feel free to correct stuff or tell me if there is stuff missing.

@kersten
Copy link
Author

kersten commented Feb 22, 2016

@daniellienert Any chance to get this merged in the next time?

@daniellienert
Copy link
Member

Hey Kersten,

thank you very much for your dedication and your changes! I really do not want to discourage you, but unfortunately I have some concerns about them.

These are:

  • There is already a "link" property in the item properties which is used for years for external linking. So we should definitely not add another.
  • In my opinion, setting the href target for every image is not handy - I would do that in the template and / or configuration. Are you sure, that you need to set it for every image differently?
  • I think there is no need to build the href target selector via a custom record selector - this could be done via flexform itself?!
  • We shouldn't have special ajax actions for these two values - I guess we should set them via the module form.

I am really willing to discuss (most of ) these concerns :)

Cheers, Daniel

@kersten
Copy link
Author

kersten commented Feb 22, 2016

OK, I get your point. Maybe I am kind of misusing your extension.

My client has a couple of sponsors and they were very easy to maintain with the gallery. So I decided to add the href to save the sponsors website URL to the image so that I am able to open the site in a new window if the user clicks on a logo.

Pixelated because I don't know if the client would be ok with that

I would like to check your other points to clear them out. Would you handle it a differently? For me this was the smartest way, because I only had to implement the layout via flex ones and not couple of times if I would use e.g. flux fal relations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants