-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add href and target to Tx_Yag_Domain_Model_Item #56
base: master
Are you sure you want to change the base?
Conversation
@daniellienert Any chance to get this merged in the next time? |
Hey Kersten, thank you very much for your dedication and your changes! I really do not want to discourage you, but unfortunately I have some concerns about them. These are:
I am really willing to discuss (most of ) these concerns :) Cheers, Daniel |
OK, I get your point. Maybe I am kind of misusing your extension. My client has a couple of sponsors and they were very easy to maintain with the gallery. So I decided to add the href to save the sponsors website URL to the image so that I am able to open the site in a new window if the user clicks on a logo. I would like to check your other points to clear them out. Would you handle it a differently? For me this was the smartest way, because I only had to implement the layout via flex ones and not couple of times if I would use e.g. flux fal relations. |
This feature makes it possible to save a custom link to the image. This makes it possible to build a theme where you can link a image to a custom site instead of opening the image or lightbox it.
This was needed for a so called "Sponsors Logo List" wehre my customer wanted a list of brands and on klick the website should open in a new window.
Feel free to correct stuff or tell me if there is stuff missing.