Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

WIP: Add serial driver #77

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

WIP: Add serial driver #77

wants to merge 4 commits into from

Conversation

micahswitzer
Copy link
Member

@micahswitzer micahswitzer commented Oct 4, 2019 •
edited
Loading

This driver is a work in progress. This is just a place to have an open discussion about how the driver should be implemented.

TODO:

  • Fix panic caused by interrupts
  • Support reading in serial data

@micahswitzer micahswitzer changed the title Add serial driver WIP: Add serial driver Oct 4, 2019
Kfeavel
Kfeavel reviewed Oct 4, 2019
View reviewed changes
Copy link
Member

@Kfeavel Kfeavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly style guide issues here. Seems fine otherwise except for the port still being in the constructor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kfeavel Kfeavel Kfeavel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahswitzer @Kfeavel