WIP fix eth_getRewardByHash by enabling storereward #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzliudan
reviewed
Nov 25, 2024
gzliudan
reviewed
Nov 25, 2024
eth/api_backend.go
Outdated
| if err == nil { | ||
| rewards := make(map[string]map[string]map[string]*big.Int) | ||
| err = json.Unmarshal(data, &rewards) | ||
| if err == nil { | ||
| log.Error("[GetRewardByHash] file found and returning rewards", "blocknum", header.Number.String()) |
There was a problem hiding this comment.
why log an error when err == nil ?
wanwiset25
force-pushed
the
enable-storereward
branch
from
578f856
to
e94316f
Compare
|
The function |
gzliudan
reviewed
Nov 25, 2024
| @@ -408,25 +408,19 @@ func (b *EthApiBackend) StateAtBlock(ctx context.Context, block *types.Block, re | |||
|
|
|||
| func (s *EthApiBackend) GetRewardByHash(hash common.Hash) map[string]map[string]map[string]*big.Int { | |||
| header := s.eth.blockchain.GetHeaderByHash(hash) | |||
| err := errors.New("header hash not found") | |||
There was a problem hiding this comment.
This line is useless sometimes, such as when return rewards.
There was a problem hiding this comment.
relocate this error declaration and put a missing hash into the message, so that whenever it logs, we know which hash is missing
gzliudan
reviewed
Nov 25, 2024
| } | ||
| } | ||
| log.Error("[GetRewardByHash]", "err", err) | ||
| return make(map[string]map[string]map[string]*big.Int) |
There was a problem hiding this comment.
Can we return nil and err if err != nil ? So API caller know the fail reason.
wanwiset25
changed the title
|
this change is not required anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyAPI
Checklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that