Remove cmt urls #1235

jmosbacher · 2023-08-11T15:59:44Z

Replace all CMT URLs with xedoc URLs
unify "cmt_version" and "xedocs_version" arguments in the context functions, replace with single "global_version" argument which loads configs from xedocs.

github-actions · 2023-08-11T16:01:07Z

straxen/plugins/afterpulses/afterpulse_processing.py

@@ -42,7 +42,7 @@ class LEDAfterpulseProcessing(strax.Plugin):

    hit_min_amplitude = straxen.URLConfig(
        track=True, infer_type=False,
-        default='cmt://hit_thresholds_tpc?version=ONLINE&run_id=plugin.run_id',
+        default='list-to-array://xedocs://hit_thresholds?as_list=True&sort=pmt&attr=value&detector=tpc&run_id=plugin.run_id&version=ONLINE',


[pep8] _{reported by reviewdog 🐶}
E501 line too long (140 > 100 characters)

github-actions · 2023-08-11T16:01:07Z

straxen/plugins/defaults.py

@@ -7,12 +7,12 @@

 NV_HIT_DEFAULTS = {
    'save_outside_hits_nv': (3, 15),
-    'hit_min_amplitude_nv': 'cmt://hit_thresholds_nv?version=ONLINE&run_id=plugin.run_id',
+    'hit_min_amplitude_nv': 'xedocs://hit_thresholds?version=ONLINE&run_id=plugin.run_id&detector=neutron_veto',


[pep8] _{reported by reviewdog 🐶}
E501 line too long (112 > 100 characters)

github-actions · 2023-08-11T16:01:07Z

straxen/plugins/defaults.py

 }

 MV_HIT_DEFAULTS = {
    'save_outside_hits_mv': (2, 5),
-    'hit_min_amplitude_mv': 'cmt://hit_thresholds_mv?version=ONLINE&run_id=plugin.run_id',
+    'hit_min_amplitude_mv': 'xedocs://hit_thresholds_mv?version=ONLINE&run_id=plugin.run_id&detector=muon_veto',


[pep8] _{reported by reviewdog 🐶}
E501 line too long (112 > 100 characters)

github-actions · 2023-08-11T16:01:07Z

straxen/plugins/events/corrected_areas.py

        help='Nominal single electron (SE) gain in PE / electron extracted. '
             'Data will be corrected to this value')

    # se gain for this run, allowing for using CMT. default to online
    se_gain = straxen.URLConfig(
-        default='cmt://se_gain?version=ONLINE&run_id=plugin.run_id',
+        default='objects-to-dict://xedocs://se_gains?run_id=plugin.run_id&version=ONLINE&partition=ab&partition=cd&as_list=True&sort=partition&key_attr=partition&value_attr=value',


[pep8] _{reported by reviewdog 🐶}
E501 line too long (180 > 100 characters)

github-actions · 2023-08-11T16:01:07Z

straxen/plugins/events/corrected_areas.py

        help='Actual SE gain for a given run (allows for time dependence)')

    # relative extraction efficiency which can change with time and modeled by CMT.
    rel_extraction_eff = straxen.URLConfig(
-        default='cmt://rel_extraction_eff?version=ONLINE&run_id=plugin.run_id',
+        default='objects-to-dict://xedocs://rel_extraction_effs?partition=ab&partition=cd&run_id=plugin.run_id&sort=partition&as_list=True&version=ONLINE&key_attr=partition&value_attr=value',


[pep8] _{reported by reviewdog 🐶}
E501 line too long (191 > 100 characters)

github-actions · 2023-08-11T16:01:09Z

straxen/plugins/peaks/peak_positions_gcn.py

-                f'?version=ONLINE'
-                f'&run_id=plugin.run_id'
-                f'&fmt=abs_path',
+        default='tf://resource://xedocs://posrec_models?attr=value&fmt=abs_path&kind=gcn&run_id=plugin.run_id&version=ONLINE',


[pep8] _{reported by reviewdog 🐶}
E501 line too long (126 > 100 characters)

github-actions · 2023-08-11T16:01:09Z

straxen/plugins/peaks/peak_positions_mlp.py

-                f'?version=ONLINE'
-                f'&run_id=plugin.run_id'
-                f'&fmt=abs_path',
+        default='tf://resource://xedocs://posrec_models?attr=value&fmt=abs_path&kind=mlp&run_id=plugin.run_id&version=ONLINE',


[pep8] _{reported by reviewdog 🐶}
E501 line too long (126 > 100 characters)

github-actions · 2023-08-11T16:01:09Z

straxen/plugins/records/records.py

@@ -109,7 +109,7 @@ class PulseProcessing(strax.Plugin):

    hit_min_amplitude = straxen.URLConfig(
        track=True, infer_type=False,
-        default='cmt://hit_thresholds_tpc?version=ONLINE&run_id=plugin.run_id',
+        default='list-to-array://xedocs://hit_thresholds?as_list=True&sort=pmt&attr=value&detector=tpc&run_id=plugin.run_id&version=ONLINE',


[pep8] _{reported by reviewdog 🐶}
E501 line too long (140 > 100 characters)

github-actions · 2023-08-11T16:01:09Z

straxen/plugins/records_he/records_he.py

@@ -31,7 +31,7 @@ class PulseProcessingHighEnergy(PulseProcessing):
        help="Number of samples per raw_record")

    hit_min_amplitude_he = straxen.URLConfig(
-        default='cmt://hit_thresholds_he?version=ONLINE&run_id=plugin.run_id', track=True, infer_type=False,
+        default='list-to-array://xedocs://hit_thresholds?as_list=True&sort=pmt&attr=value&detector=tpc_he&run_id=plugin.run_id&version=ONLINE', track=True, infer_type=False,


[pep8] _{reported by reviewdog 🐶}
E501 line too long (173 > 100 characters)

github-actions · 2023-08-11T16:01:09Z

straxen/plugins/records_nv/records_nv.py

@@ -43,7 +43,7 @@ class nVETOPulseProcessing(strax.Plugin):

    baseline_samples_nv = straxen.URLConfig(
        infer_type=False,
-        default='cmt://baseline_samples_nv?version=ONLINE&run_id=plugin.run_id', track=True,
+        default='xedocs://baseline_samples_nv?attr=value&run_id=plugin.run_id&version=ONLINE', track=True,


[pep8] _{reported by reviewdog 🐶}
E501 line too long (106 > 100 characters)

for more information, see https://pre-commit.ci

GiovanniVolta · 2024-11-18T16:27:25Z

@LuisSanchez25 is this PR important for migrating from CMT to xedocs?

LuisSanchez25 · 2024-11-18T16:36:38Z

Depends what you mean by it. This PR mainly changes the default values is straxen, which are rarely used anyways, so it should not affect the processing of things, however, to transition to xedocs fully this is something that should be done eventually but its not immediately necessary.

The main issue I believe is that there are some tests that are designed around CMT that we need to rewrite to work with xedocs. I will ask @Ananthu-Ravindran if he thinks he could work on this.

GiovanniVolta · 2024-11-18T16:44:12Z

Let me also remind you that @PeterGy offers his help for xedocs-related business. This is good way to start

PeterGy · 2024-11-19T20:16:17Z

It seems the logs for what tests fail have been deleted due to lack of retention (the tests were ran back in April). It would be useful to rerun them to see where and how they fail. Unfortunately, I do not seem to have permission to rerun any tests on this repo.

LuisSanchez25 · 2024-11-19T22:22:52Z

It seems the logs for what tests fail have been deleted due to lack of retention (the tests were ran back in April). It would be useful to rerun them to see where and how they fail. Unfortunately, I do not seem to have permission to rerun any tests on this repo.

One the conflicts are squashed we can make this into a PR instead of a draft PR, then the tests will run automatically

jmosbacher added 2 commits August 11, 2023 18:25

remove cmt from contexts.py

e3e141e

remove cmt from plugin config defaults

1de9017

github-actions bot reviewed Aug 11, 2023

View reviewed changes

dachengx and others added 8 commits September 2, 2023 20:21

Merge branch 'master' into remove_cmt_urls

abf44ab

Merge branch 'master' into remove_cmt_urls

5fe5727

merge with master

c6a049c

merge conflicts with master

5533548

solve context conflicts + merge with master

cdb575b

[pre-commit.ci] auto fixes from pre-commit.com hooks

2b6bb96

for more information, see https://pre-commit.ci

global_version -> xedocs_version

6136791

[pre-commit.ci] auto fixes from pre-commit.com hooks

e7d238b

for more information, see https://pre-commit.ci

dachengx requested review from MerzJohannes and dachengx November 20, 2024 06:24

dachengx mentioned this pull request Nov 20, 2024

Remove CMT #1475

Open

Merge branch 'master' into remove_cmt_urls

86a21a8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove cmt urls #1235

Remove cmt urls #1235

jmosbacher commented Aug 11, 2023

github-actions bot Aug 11, 2023

github-actions bot Aug 11, 2023

github-actions bot Aug 11, 2023

github-actions bot Aug 11, 2023

github-actions bot Aug 11, 2023

github-actions bot Aug 11, 2023

github-actions bot Aug 11, 2023

github-actions bot Aug 11, 2023

github-actions bot Aug 11, 2023

github-actions bot Aug 11, 2023

GiovanniVolta commented Nov 18, 2024 •

edited

Loading

LuisSanchez25 commented Nov 18, 2024

GiovanniVolta commented Nov 18, 2024

PeterGy commented Nov 19, 2024

LuisSanchez25 commented Nov 19, 2024

Remove cmt urls #1235

Are you sure you want to change the base?

Remove cmt urls #1235

Conversation

jmosbacher commented Aug 11, 2023

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

github-actions bot Aug 11, 2023

Choose a reason for hiding this comment

GiovanniVolta commented Nov 18, 2024 • edited Loading

LuisSanchez25 commented Nov 18, 2024

GiovanniVolta commented Nov 18, 2024

PeterGy commented Nov 19, 2024

LuisSanchez25 commented Nov 19, 2024

GiovanniVolta commented Nov 18, 2024 •

edited

Loading