Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations & Errors corrected. #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MadCatMining
Copy link
Contributor

Deprecation warnings are gone under NodeJS v8.17.0. No errors during tests in live Discord server.

Thought - as much as I understand - it is better to block already verified users from writing in "verification" channel as user ID gets written multiple times in Query.json if user fails to register from the first time, gets kicked and re-joins, starts verification process again. In this case - after user gets finally verified, receives a new role and types a !verify command again in "verification" channel - he can loop this process to infinity, with each loop inflating Query.json file.

Modified index.js to get rig of errors with newer discord API version. Modifies procedure message sent by bot to new users.
Modified config.json to add option for index.js for newer Discord API.
Deprecation warnings are gone under NodeJS  v8.17.0. No errors during tests in live Discord server.
Thought - as much as I understand - it is better to block already verified users from writing in "verification" channel as user ID gets written multiple times in Query.js if user fails to register from the first time, gets kicked and re-joins, starts verification process again. In this case - after user gets finally verified, receives a new role and types a `!verify` command again it "verification" channel - he can loop this process to infinity, with each loop filling/expanding Query.js file.
Got rid off one more Deprecation Warning coming from sending User kick message.
@X-Rubick
Copy link
Owner

approved it, sorry for the delay

@X-Rubick
Copy link
Owner

approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants