Fix the detection logic for opening faction-specific containers #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a faction-specific item is obtained from a container, such as the mounts from Time Rift boxes, then the detection adds an attempt for it even though the player's faction doesn't match the requirement. This fix is "hacky" because I don't dare to touch the nested loops right now; ideally it'd be tested via CI and probably restructured a bit, but that will just have to wait (unfortunately).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a faction-specific item is obtained from a container, such as the mounts from Time Rift boxes, then the detection adds an attempt for it even though the player's faction doesn't match the requirement. This fix is "hacky" because I don't dare to touch the nested loops right now; ideally it'd be tested via CI and probably restructured a bit, but that will just have to wait (unfortunately).