Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RM-217585 FED-1716 Release react-dart 7.0.0 (null-safety) #380

Merged
merged 73 commits into from
Nov 10, 2023
Merged

RM-217585 FED-1716 Release react-dart 7.0.0 (null-safety) #380

merged 73 commits into from
Nov 10, 2023

Commits on Aug 16, 2023

  1. Remove deprecated forwardRef 

    It can't really be made null safe, and we always intended on
removing it in the next major.
    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3dd457e View commit details
    Browse the repository at this point in the history

  2. Remove workaround for dart-lang/sdk#27647, fixed in Dart 2

    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    cd2eda7 View commit details
    Browse the repository at this point in the history

  3. Migrate to null safety

    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    ae23239 View commit details
    Browse the repository at this point in the history

  4. Use Never since Null is no longer the bottom type

    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3109175 View commit details
    Browse the repository at this point in the history

  5. Fix lints

    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    9b2379e View commit details
    Browse the repository at this point in the history

  6. Fix instances of dynamic?

    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    f1101b7 View commit details
    Browse the repository at this point in the history

  7. Fix more implicit casts in examples

    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1c88f0f View commit details
    Browse the repository at this point in the history

  8. Update mocks to work in null safety by using mockito's builder

    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d7cd354 View commit details
    Browse the repository at this point in the history

  9. Address fixme around createReactDartComponentClass(2) nullability

    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4176a9e View commit details
    Browse the repository at this point in the history

  10. Address fixme around handling a null SyntheticEvent.type

    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    5adad69 View commit details
    Browse the repository at this point in the history

  11. Address fixme around accessing uninitialized late props/state fields … 

    …in tests
    @greglittlefield-wf
    greglittlefield-wf committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    af89ed3 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Support non-nullable refs, remove unsafe Ref constructors

    @greglittlefield-wf
    greglittlefield-wf committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    961aa4a View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Fix useRef deprecation warnings, add useRef2 tests

    @greglittlefield-wf
    greglittlefield-wf committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6024c37 View commit details
    Browse the repository at this point in the history

  2. Remove FIXME for Simulated event nullability (more info below) 

    Simulated synthetic events will be missing some properties if they're
not included in eventData, meaning the non-nullable typings on them
are incorrect.

As opposed to making everything nullable to account for that, we'll
treat those simulated events the same way Mockito treats mock objects,
and just require that any properties being accessed get stubbed in using
the eventData argument.
    @greglittlefield-wf
    greglittlefield-wf committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    4aed55f View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Improve typing and safety of initComponentInternal

    @greglittlefield-wf
    greglittlefield-wf committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    71f519a View commit details
    Browse the repository at this point in the history

  2. Improve comment

    @greglittlefield-wf
    greglittlefield-wf committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    4fa6b9d View commit details
    Browse the repository at this point in the history

  3. Make ReactDartComponentInternal.props non-nullable

    @greglittlefield-wf
    greglittlefield-wf committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    e7f2e9e View commit details
    Browse the repository at this point in the history

  4. Eliminate ! operator from state initialization

    @greglittlefield-wf
    greglittlefield-wf committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d807613 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Fix bad non-null assertion

    @greglittlefield-wf
    greglittlefield-wf committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    90d911e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Improve useRef nullability by deprecating its argument instead of 

    versioning it

useRef without an argument is more common than with one, and this
approach improves that experience by:
 1. not requiring consumers explicitly provide `null` and provide
    a nullable type argument
 2. not involving a new, versioned API that must be migrated to
    @greglittlefield-wf
    greglittlefield-wf committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0dc260e View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Remove duplicate PropValidator typedef, align typing

    @greglittlefield-wf
    greglittlefield-wf committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    1a06d48 View commit details
    Browse the repository at this point in the history

  2. Fix deprecated initial value in useRef not being passed along

    @greglittlefield-wf
    greglittlefield-wf committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    f2ad196 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Pull in RefTestCase changes from over_react 

    Importantly, this fixes some callback ref typing issues after
fixing unnecessary_lambdas lints
    @greglittlefield-wf
    greglittlefield-wf committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    0c561dc View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. assert that callback ref arguments aren't non-nullable, add tests

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    61cc34d View commit details
    Browse the repository at this point in the history

  2. Make chainRefs AssertionError tests more specific

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    11ca3a7 View commit details
    Browse the repository at this point in the history

  3. Remove unused import

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    abe5735 View commit details
    Browse the repository at this point in the history

  4. Remove implements Function which has had no effect since Dart 2.0

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    37a47f6 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary ReactElement casts

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a6f96f8 View commit details
    Browse the repository at this point in the history

  6. Fix most remaining implicit casts

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    069f478 View commit details
    Browse the repository at this point in the history

  7. Add types to top-level DOM factories, clean up casts

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b9881a1 View commit details
    Browse the repository at this point in the history

  8. Add tests for how JsBackedMap handles null and other key types

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8799ed2 View commit details
    Browse the repository at this point in the history

  9. JsBackedMap: fix errors when using null keys, fix implicit casts

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0d1ab08 View commit details
    Browse the repository at this point in the history

  10. Fix find/replace typo

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d708dfd View commit details
    Browse the repository at this point in the history

  11. Add test case for null key within Map passed to jsifyAndAllowInterop

    @greglittlefield-wf
    greglittlefield-wf committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    019cabc View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Disable implicit casts in analysis options

    @greglittlefield-wf
    greglittlefield-wf committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8122645 View commit details
    Browse the repository at this point in the history

  2. Adjust Component2Bridge.forComponent nullability 

    This could be null for components that haven't been mounted yet,
so we'll let the (small number of) consumers perform that null
check instead.
    @greglittlefield-wf
    greglittlefield-wf committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    50e9a5e View commit details
    Browse the repository at this point in the history

  3. Tweak createContext for better type promotion

    @greglittlefield-wf
    greglittlefield-wf committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    2c380ce View commit details
    Browse the repository at this point in the history

  4. Clean up FIXME

    @greglittlefield-wf
    greglittlefield-wf committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e4d6570 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Format

    @greglittlefield-wf
    greglittlefield-wf committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    d75e962 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'prepare-for-7_0_0' into null-safety-manual-2

    @greglittlefield-wf
    greglittlefield-wf committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    c23fffc View commit details
    Browse the repository at this point in the history

  3. Remove deprecated StateHook and ReducerHook constructors

    @greglittlefield-wf
    greglittlefield-wf committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e86096b View commit details
    Browse the repository at this point in the history

  4. Fix and expand on non-nullable callback ref assertion message

    @greglittlefield-wf
    greglittlefield-wf committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    c26f942 View commit details
    Browse the repository at this point in the history

  5. Fix logic change during migration 

    The logic change being fixed here didn't seem to affect tests, but
preferring props over staticProps seemed more appropriate.
    @greglittlefield-wf
    greglittlefield-wf committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    40a2e19 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Use dart_dev to format so that we can exclude generated mockito files

    @greglittlefield-wf
    greglittlefield-wf committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    a385e95 View commit details
    Browse the repository at this point in the history

  2. Fix conflicting outputs in CI, also fix tests not running in dart2js 

    It seems like we didn't have --release when we should have for dart2js
tests.
    @greglittlefield-wf
    greglittlefield-wf committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    95628fc View commit details
    Browse the repository at this point in the history

  3. Add missing glob dev dependency

    @greglittlefield-wf
    greglittlefield-wf committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    086f8cb View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Seal ReducerHook, StateHook, and Ref

    @greglittlefield-wf
    greglittlefield-wf committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    a284dfc View commit details
    Browse the repository at this point in the history

  2. Clean up cast

    @greglittlefield-wf
    greglittlefield-wf committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    7ca0cb8 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Remove deprecated APIs

    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7a27606 View commit details
    Browse the repository at this point in the history

  2. Make deprecated APIs private

    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    40e4efd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'more-v7-deprecations' into v7-removals

    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    36c5933 View commit details
    Browse the repository at this point in the history

  4. Make more deprecated APIs private

    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    91c9c2c View commit details
    Browse the repository at this point in the history

  5. Update changelog with more deprecated API removals

    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6adb2d1 View commit details
    Browse the repository at this point in the history

  6. Sort list of deprecated API removals

    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    597c2b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Fix bad generic typing on Object.keys

    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    dbcf43a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Address CR feedback

    @greglittlefield-wf
    greglittlefield-wf committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ee90271 View commit details
    Browse the repository at this point in the history

  2. Add more thorough explanation of impact of late member changes

    @greglittlefield-wf
    greglittlefield-wf committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b277b9a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Add typedef and comments to explain StateHook _setValue typing

    @greglittlefield-wf
    greglittlefield-wf committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7ab1084 View commit details
    Browse the repository at this point in the history

  2. Align nullability of context args in 

    componentWillUpdateWithContext/shouldComponentUpdateWithContext
    @greglittlefield-wf
    greglittlefield-wf committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0616cd0 View commit details
    Browse the repository at this point in the history

  3. Address CR feedback

    @greglittlefield-wf
    greglittlefield-wf committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    cb5cfd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge pull request #373 from Workiva/null-safety-manual-2 

    FED-1728 Migrate to null safety
    @rmconsole2-wf
    rmconsole2-wf authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1919cc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Merge branch 'v7_wip' into v7-removals

    @greglittlefield-wf
    greglittlefield-wf committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    02e6f10 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #375 from Workiva/v7-removals 

    FED-1727 Remove the rest of the deprecated APIs for v7
    @rmconsole2-wf
    rmconsole2-wf authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    440c5e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge remote-tracking branch 'origin/master' into v7_wip

    @greglittlefield-wf
    greglittlefield-wf committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    2d3642d View commit details
    Browse the repository at this point in the history

  2. Bump version for 7.0.0 release

    @greglittlefield-wf
    greglittlefield-wf committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ce10f1e View commit details
    Browse the repository at this point in the history

  3. Clean up changelog entry

    @greglittlefield-wf
    greglittlefield-wf committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a100009 View commit details
    Browse the repository at this point in the history

  4. Format API names as code

    @greglittlefield-wf
    greglittlefield-wf committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    96fdb07 View commit details
    Browse the repository at this point in the history

  5. Sort deprecated APIs in changelog

    @greglittlefield-wf
    greglittlefield-wf committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e23f8a9 View commit details
    Browse the repository at this point in the history

  6. Mark dartInteropStatics internal, remove from changelog since it was 

    never public
    @greglittlefield-wf
    greglittlefield-wf committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0218473 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Add regression test for mocked SyntheticEvent class type-checking

    @greglittlefield-wf
    greglittlefield-wf committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    1220e25 View commit details
    Browse the repository at this point in the history

  2. Update regression tests

    @greglittlefield-wf
    greglittlefield-wf committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    70cc2b7 View commit details
    Browse the repository at this point in the history

  3. Update _checkEventType to respect mocks that mock type

    @greglittlefield-wf
    greglittlefield-wf committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    11e485e View commit details
    Browse the repository at this point in the history

  4. Merge pull request #381 from Workiva/fix-mocked-event-types 

    FED-1881 Fix regression in SyntheticEvent mock class type-checking
    @rmconsole2-wf
    rmconsole2-wf authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b27803c View commit details
    Browse the repository at this point in the history