enabled wheel preventing only for scroll behavior, other pr suggestio…

…ns addressed
WiseTechGlobal · Jul 10, 2024 · 3d0517e · 3d0517e
1 parent cfa5fec
commit 3d0517e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/site/Site/Pages/Documentation/Diagram/Behaviors.razor b/site/Site/Pages/Documentation/Diagram/Behaviors.razor
@@ -120,11 +120,10 @@ You can use the following ways to add different behaviors to the diagram.
 
 <h3>Scroll Behavior</h3>
 
-<p>To scroll the diagram using the mouse wheel you can register the Scroll Behavior.</p>
+<p>To scroll the diagram using the mouse wheel use ScrollBehavior.</p>
 
 <pre><code class="language-cs">
-Diagram.UnregisterBehavior&lt;WheelBehavior&gt;();
-Diagram.RegisterBehavior(new ScrollBehavior(Diagram));
+_diagram.BehaviorOptions.DiagramWheelBehavior = _diagram.GetBehavior&lt;ScrollBehavior&gt;();
 </code></pre>
 
 

diff --git a/src/Blazor.Diagrams/Components/DiagramCanvas.razor.cs b/src/Blazor.Diagrams/Components/DiagramCanvas.razor.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Threading.Tasks;
+using Blazor.Diagrams.Core.Behaviors;
 using Blazor.Diagrams.Core.Geometry;
 using Blazor.Diagrams.Extensions;
 using Microsoft.AspNetCore.Components;
@@ -64,7 +65,10 @@ protected override async Task OnAfterRenderAsync(bool firstRender)
         {
             BlazorDiagram.SetContainer(await JSRuntime.GetBoundingClientRect(elementReference));
             await JSRuntime.ObserveResizes(elementReference, _reference!);
-            await JSRuntime.AddDefaultPreventingHandler(elementReference);
+            if (BlazorDiagram.GetBehavior<ScrollBehavior>() != null)
+            {
+                await JSRuntime.AddDefaultPreventingForWheelHandler(elementReference);
+            }
         }
     }
 
@@ -102,7 +106,7 @@ private void OnKeyDown(KeyboardEventArgs e)
         BlazorDiagram.TriggerKeyDown(e.ToCore());
     }
 
-    private async void OnWheel(WheelEventArgs e)
+    private void OnWheel(WheelEventArgs e)
     {
         BlazorDiagram.TriggerWheel(e.ToCore());
     }

diff --git a/src/Blazor.Diagrams/Extensions/JSRuntimeExtensions.cs b/src/Blazor.Diagrams/Extensions/JSRuntimeExtensions.cs
@@ -31,7 +31,7 @@ public static async Task UnobserveResizes(this IJSRuntime jsRuntime, ElementRefe
         await jsRuntime.InvokeVoidAsync("ZBlazorDiagrams.unobserve", element, element.Id);
     }
 
-    public static async Task AddDefaultPreventingHandler(this IJSRuntime jsRuntime, ElementReference element)
+    public static async Task AddDefaultPreventingForWheelHandler(this IJSRuntime jsRuntime, ElementReference element)
     {
         await jsRuntime.InvokeVoidAsync("ZBlazorDiagrams.addDefaultPreventingHandler", element, "wheel");
     }