Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor advanced.yml so that matrix strategy is moved to a parent workflow #132

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Blackhex
Copy link
Member

@Blackhex Blackhex commented Apr 12, 2024

Moves matrix strategy from advanced.yml up to a parent workflow called variants.yml calling the advanced.yml as reusable workflow. This refactor allows to run tests for other targets from the matrix. One caveat is that now the job graph does not look as nice as before.

@Blackhex Blackhex force-pushed the parent-matrix branch 9 times, most recently from 6cb6725 to 9a7812d Compare April 12, 2024 20:41
@Blackhex Blackhex requested a review from eukarpov April 14, 2024 19:32
@Blackhex Blackhex marked this pull request as ready for review April 14, 2024 19:32
@Blackhex
Copy link
Member Author

Blackhex commented Aug 1, 2024

@eukarpov Would you accept this change if individual workflows (one for each configuration) calling re-usable workflows would be used instead of the matrix? It would be less conscise and maintainable but the graph visualization would stay.

@eukarpov
Copy link
Member

eukarpov commented Aug 1, 2024

@eukarpov Would you accept this change if individual workflows (one for each configuration) calling re-usable workflows would be used instead of the matrix? It would be less conscise and maintainable but the graph visualization would stay.

My personal preference is to have good visualization. Sometimes I need to switch quickly between different PRs and custom CI runs. Good visualization helps to get quick summary about CI current progress.
For the patch series it will be hard to understand what is happening when 1k+ jobs are executed.

@Blackhex Blackhex force-pushed the parent-matrix branch 2 times, most recently from 0ffbe5d to 5852a71 Compare September 5, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants