Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #238
Time
time for i in {1..5}; _build/release/bin/erlfmt -w 'otp/lib/*/{src,include}/*.{erl,hrl}'; done
Main
real 0m43.746s
user 1m51.063s
sys 0m39.859s
This
real 0m36.764s
user 1m35.922s
sys 0m34.750s
Potential incompatibility
Changed return of
format_[file, file_range, string_full, string_range]
to include the original. Type of formatted string from[unicode:chardata()]
tostring()
.Possible alternative: Introduce new tag
unchanged
.Question
Can format_file_range be removed?