Redundant class removed #345 #344

Redundant class `ClientManager::class` removed and config handling moved to depending library "webklex/php-imap" #345 #344
Webklex · Oct 8, 2020 · 3950cc2 · 3950cc2
1 parent 706d6c7
commit 3950cc2
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 139 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,13 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
 ### Breaking changes
 - NaN 
 
+## [2.1.0] - 2020-10-08
+### Fixed
+- Redundant class `ClientManager::class` removed and config handling moved to depending library "webklex/php-imap" #345 #344
+
+### Breaking changes
+- `\Webklex\IMAP\ClientManager::class` no longer exists. Please use the `\Webklex\IMAP\Facades\Client::class` facade or `\Webklex\PHPIMAP\ClientManager::class` instead. 
+
 ## [2.0.2] - 2020-09-23
 ### Fixed
 - Missing default config parameter added (#337)

diff --git a/src/ClientManager.php b/src/ClientManager.php
diff --git a/src/Facades/Client.php b/src/Facades/Client.php
@@ -13,7 +13,7 @@
 namespace Webklex\IMAP\Facades;
 
 use Illuminate\Support\Facades\Facade;
-use Webklex\IMAP\ClientManager;
+use Webklex\PHPIMAP\ClientManager;
 
 /**
  * Class Client

diff --git a/src/Providers/LaravelServiceProvider.php b/src/Providers/LaravelServiceProvider.php
@@ -13,7 +13,7 @@
 namespace Webklex\IMAP\Providers;
 
 use Illuminate\Support\ServiceProvider;
-use Webklex\IMAP\ClientManager;
+use Webklex\PHPIMAP\ClientManager;
 use Webklex\PHPIMAP\Client;
 
 /**
@@ -40,15 +40,15 @@ public function boot() {
      * @return void
      */
     public function register() {
+        $this->setVendorConfig();
+
         $this->app->singleton(ClientManager::class, function($app) {
-            return new ClientManager($app);
+            return new ClientManager($app['config']["imap"]);
         });
 
         $this->app->singleton(Client::class, function($app) {
             return $app[ClientManager::class]->account();
         });
-
-        $this->setVendorConfig();
     }
 
     /**