Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine groups UI - fixes #2938 #3099

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

benfrancis
Copy link
Member

@benfrancis benfrancis commented Aug 10, 2023

Closes #2938. Supercedes #2991.

  • Adds an overflow menu to the add thing button to add either a thing or a group
  • Adds a dedicated add thing screen
  • Refines the overflow menu design
  • Refines the group "context menu"
  • Refines the group UI design including fixed width groups and new icons
  • Fixes the overlapping groups bug and refines scrolling behaviour

Also:

  • Replaces lots of nested divs and spans with more semantic HTML
  • Uses HTML form elements for forms in order to take advantage of built-in client-side validation

TODO:

  • Fix re-arranging groups, which got a bit broken along the way
  • Optimise for mobile
  • Make linter happy

Follow-ups:

@benfrancis
Copy link
Member Author

@bewee I did some work on polishing the groups UI with a view to getting it released (that was some great work you did BTW).

I've slightly broken re-arranging groups in the process (the white dotted separator doesn't appear in the right place when dragging and dropping). I'm hoping to take another look at it tomorrow before fixing any broken tests etc. and then submitting this PR for review. If you happen to have time to take a look you may figure out the problem before me!

@benfrancis
Copy link
Member Author

benfrancis commented Aug 11, 2023

I've slightly broken re-arranging groups
If you happen to have time to take a look you may figure out the problem before me!

@bewee Never mind, I think I've fixed it.

@benfrancis benfrancis merged commit 10320bb into WebThingsIO:master Aug 29, 2023
0 of 3 checks passed
This was referenced Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine Groups UI
2 participants