Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffusion lim atmesc change #244

Merged
merged 9 commits into from
Aug 22, 2023
Merged

Diffusion lim atmesc change #244

merged 9 commits into from
Aug 22, 2023

Conversation

mgialluca
Copy link
Contributor

Proposed changes

Describe your changes here to communicate to the maintainers the value of this pull request (PR). If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your PR introduce to VPLanet?
Put an x in the boxes that apply

  • Bugfix (non-breaking change that fixes an issue)
  • [ X] New feature (non-breaking change that adds functionality)
  • New module (non-breaking change that adds a new module)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of the steps that are necessary before merging your PR.

  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [ X] I have adhered to the Style or run the clang format code shown here
  • [X ] I have added necessary documentation (if appropriate)
  • I have run Valgrind on new tests to ensure no errors were found
  • [ X] (Optional) I have added an example showcasing the new change

Further comments

If this is a relatively large or complex change, explain why you chose the solution you did, what alternatives you considered, or anything else you believe to be relevant.

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

Unit Test Results

14 440 tests  +258   14 440 ✔️ +258   4m 45s ⏱️ +14s
         1 suites ±    0            0 💤 ±    0 
         1 files   ±    0            0 ±    0 

Results for commit 0fa56b5. ± Comparison against base commit 65a31dc.

♻️ This comment has been updated with latest results.

@RoryBarnes RoryBarnes merged commit cdb90bc into main Aug 22, 2023
7 checks passed
@mgialluca mgialluca deleted the DiffusionLimAtmescChange branch January 3, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants